Skip to content

Fix flaky test cases for user role and level update in users list #7042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Fix flaky test cases for user role and level update in users list #7042

wants to merge 5 commits into from

Conversation

@suzit-10
Copy link
Contributor

@suzit-10 suzit-10 commented Sep 24, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Describe this PR

This PR addresses the flakiness in the UsersList and teams edit test cases.
The root cause was the inconsistent rendering of the pop-up triggered by the table rows due to asynchronous TanStack Table rendering and team edit form details.

Changes made:

  • Ensured test setup waits for loading animation to disappear and rows/triggers to be fully rendered.
  • Replaced waitFor(getBy...) with findByTestId for stable async querying.
  • Used queryByTestId instead of stale references when validating popup unmount.
  • Introduce test retries for better handling of intermittent failure

@suzit-10 suzit-10 force-pushed the fix/test-case-flikyness branch from dedccb7 to b9e2e77 Compare October 16, 2025 10:34
@suzit-10 suzit-10 force-pushed the fix/test-case-flikyness branch from b3beb8f to f66ff98 Compare October 16, 2025 10:58
@suzit-10 suzit-10 force-pushed the fix/test-case-flikyness branch from 59fc7ae to 4c34651 Compare October 31, 2025 04:36
@pre-commit-ci pre-commit-ci bot deployed to 7042/merge October 31, 2025 04:37 Active
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 31, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

suzit-10 added a commit to naxa-developers/tasking-manager that referenced this pull request Nov 3, 2025
@suzit-10
Merge branch 'fix/mapping-level-naming' into test/pr-#7061-hotosm#7062-…
e2d0b45 
…hotosm#7063-hotosm#7058-hotosm#7045-hotosm#7046-hotosm#7042-hotosm#7041
suzit-10 added a commit to naxa-developers/tasking-manager that referenced this pull request Nov 3, 2025
@suzit-10
Merge branch 'fix/follow-up-team-unlink-error-message' into test/pr-#…
8670a28 
…7061-hotosm#7062-hotosm#7063-hotosm#7058-hotosm#7045-hotosm#7046-hotosm#7042-hotosm#7041
suzit-10 added a commit to naxa-developers/tasking-manager that referenced this pull request Nov 3, 2025
@suzit-10
Merge branch 'fix/7030-changing-basemap-kills-project-boundary' into …
52b2e77 
…test/pr-#7061-hotosm#7062-hotosm#7063-hotosm#7045-hotosm#7046-hotosm#7042-hotosm#7041
suzit-10 added a commit to naxa-developers/tasking-manager that referenced this pull request Nov 3, 2025
@suzit-10
Merge branch 'pr-6938' into test/pr-#7061-hotosm#7062-hotosm#7063-hot…
c024be6 
…osm#7045-hotosm#7046-hotosm#7042-hotosm#7041
suzit-10 added a commit to naxa-developers/tasking-manager that referenced this pull request Nov 3, 2025
@suzit-10
Merge branch 'fix/test-case-flikyness' into test/pr-#7061-hotosm#7062-h…
32601c7 
…otosm#7063-hotosm#7045-hotosm#7046-hotosm#7042-hotosm#7041
@ramyaragupathy ramyaragupathy requested a review from emi420 November 4, 2025 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emi420 emi420 Awaiting requested review from emi420

Assignees

No one assigned

Labels

scope: frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suzit-10